Attention is currently required from: fixeria.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923?usp=email )

Change subject: erab_fsm: Abort and reply call with error if unable to establish PFCP sess ......................................................................

Patch Set 1:

(2 comments)

File src/erab_fsm.erl:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/edd7588b_3510a... : PS1, Line 176: next_state, ?FUNCTION_NAME, S, %% loop transition to enable state_timeout

Ok, I see you have also changed the loop transition to `keep_state` in the `pfcp_peer` (Ic17c1c7210a […]

I'm leaving it the way it was before though I think having keep_state is preferred here as it works fine so far.

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37923/comment/45aa68da_fe38c... : PS1, Line 179: {stop_and_reply,

(cosmetic) Also, please move the case body to the next line for consistency with the existing code ( […]

Done