Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32968 )
Change subject: all models, HR1 codec: accept both TS101318 and RFC5993 formats ......................................................................
Patch Set 1:
(2 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32968/comment/314d2739_6cae088d PS1, Line 1264: static bool rtppayload_validate_hr(struct msgb *msg) this function is now not really validating, but converting.
https://gerrit.osmocom.org/c/osmo-bts/+/32968/comment/744dcb45_eec57948 PS1, Line 1270: case GSM_HR_BYTES_RTP_RFC5993: so here we remove the ToC information. What if lower layers (eg a DSP backend) requires payload in RFC5993 because it wants that information to apply whatever? does that make sense?