Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email )
Change subject: Rework SGSN code to use new libvlr code ......................................................................
Patch Set 17:
(3 comments)
Patchset:
PS17: Some of my comments were still not addressed.
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/36f8c672_76331287?usp... : PS17, Line 2602: osmo_vlr_set_log_cat(OSMO_VLR_LOGC_VLR, DVLR); If we can set the log category here, I wonder why it does use the SGS category hardcoded as you mentioned in the other file...
File src/sgsn/gprs_rau_fsm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7bb93854_f7104f99?usp... : PS16, Line 76: static void gmm_rau_fsm_s_init(struct osmo_fsm_inst *fi, uint32_t event, void *data)
Why is the file called "gprs_rau_fsm" vs all the types/functions being called "gmm_rau_fsm"? Please […]
Done
-
pespin