Attention is currently required from: arehbein, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email ) Change subject: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd() ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/35073/comment/55e013c9_1d217a24 PS1, Line 12: illagal

illegal Done

File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35073/comment/93c270ae_5f3da6a8 PS1, Line 846: asp->sock_name = osmo_sock_get_name(asp, fd);

`osmo_sock_get_name_buf()` (which will be called) does check for `fd < 0`, not sure if we also want […] Done

-- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I12c66badfb4bdfdfe71f1716de960d353d3548b1 Gerrit-Change-Number: 35073 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Sat, 25 Nov 2023 16:31:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: arehbein <arehbein@sysmocom.de> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Gerrit-MessageType: comment