Attention is currently required from: laforge, pespin, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33548 ) Change subject: ASCI: Support conference briding with 1..n connections ...................................................................... Patch Set 4: (4 comments) File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/7f350143_754cb1b4 PS4, Line 176: /* Do not allow more then the maximum number of connections */

you could take the cance to fix the "then" typo :D Done

https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/cf710cd3_d42bcb8c PS4, Line 177: if (endp->type->max_conns && llist_count(&endp->conns) >= endp->type->max_conns)

max_conns > 0 may be clearer here. Done

File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/ebb64768_f7bf8b49 PS4, Line 1329: if (conn->mode != MGCP_CONN_RECV_ONLY &&

sounds like you want to use a switch() here? It's difficult to gasp the different cases otherwise. Done

https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/4cab3239_b21b8be6 PS4, Line 1342: if (conn_dst->mode == MGCP_CONN_SEND_ONLY ||

Also lots of mode checking here. […] Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic99a55ab5a3a6170e940403fadd52697e99f2f3a Gerrit-Change-Number: 33548 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jul 2023 10:16:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment