daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32181 )
Change subject: tests: Add initial osmo_io tests
......................................................................
Patch Set 2:
(1 comment)
File tests/osmo_io/osmo_io_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/7d02f4c7_cc8e421a
PS1, Line 144: for (int i = 0; i < 128; i++) {
braces {} are not necessary for single statement
blocks
tbh I'm really not a fan of this rule since it's really easy to get bitten by it
during a refactoring.
At least there are now warnings when the indentation level doesn't match the assumed
control flow...
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32181
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia67629e53f4d2e5784177250d58e268fdfcaa0c2
Gerrit-Change-Number: 32181
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 31 Mar 2023 18:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment