[L] Change in libosmocore[master]: codec: replace GSM-FR ECU with new implementation - gerrit-log

15 May 2023


      Attention is currently required from: laforge, dexter.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 )
Change subject: codec: replace GSM-FR ECU with new implementation
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/codec/ecu.h:
https://gerrit.osmocom.org/c/libosmocore/+/32685/comment/248ff8b3_6259a5db 
PS3, Line 9: /* ECU state for GSM-FR - deprecated version only! */
...
It is not so clear why we keep this. […]
The old implementation _with its state structure_ is a public API of its own, predating the abstracted ECU API, and at least gapk still uses that old, officially deprecated API - and "uses" not only in the sense of calling the old functions, but gapk code actually digs inside that struct osmo_ecu_fr_state!
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0200e423ca6165c1313ec9a4effc3f3047f5f032
Gerrit-Change-Number: 32685
Gerrit-PatchSet: 3
Gerrit-Owner: falconia falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 15 May 2023 16:47:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter pmaier@sysmocom.de
Gerrit-MessageType: comment