Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 ) Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case ...................................................................... Patch Set 2: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32128/comment/43b3024e_795e31e3 PS1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0);

I did not realize that passing a NULL pointer was allowed, for some reason I thought it had to be a […] well if len = 0, then it makes no sense to access to buffer, so it shouldn't expect it to be non-null in that case. The question is more whether it's fine to have len=0 on that path, but I think it ws the case before right?

-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c Gerrit-Change-Number: 32128 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: falconia <falcon@freecalypso.org> Gerrit-Comment-Date: Wed, 29 Mar 2023 18:36:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon@freecalypso.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment