Attention is currently required from: neels, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29122 ) Change subject: Revert "Add function to guess AF_UNSPEC address" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1:

I disagree - see osmo_ip_str_type(): this function is just convenience wrapper over it. […] osmo_ip_str_type operates on a text string, which will contain an address. i guess the perceived danger of this new function is that there is code that doesnt set the AF?more explanation and/or examples required

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23 Gerrit-Change-Number: 29122 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: msuraev <msuraev@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:22:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev@sysmocom.de> Gerrit-MessageType: comment