Attention is currently required from: arehbein, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email ) Change subject: osmo-bsc: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 2: Verified+1 Code-Review+1 (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33891/comment/eb2e81e8_f699fae8 PS2, Line 725: "%u messages waiting). Closing connection\n", We usually try to avoid breaking strings since it makes it them harder to grep. This is also what kernel coding style recommends. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Thu, 07 Sep 2023 16:15:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment