Attention is currently required from: osmith, pespin, fixeria.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/30785 )
Change subject: Move some functions gprs_gb.[c,h] -> gprs_gmm.[c,h]
......................................................................
Patch Set 4:
(1 comment)
File src/sgsn/gprs_sndcp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/30785/comment/938618c1_436ecd54
PS4, Line 44:
It's better to keep the empty line separating includes from defines - makes it easier
to read.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/30785
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3dcbe1d0f75cb91ec8b700e239e2ba16fff030a2
Gerrit-Change-Number: 30785
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Dec 2022 18:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment