lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43697?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mmctx: only dispatch mm_state_fsm when not DETACHED/IDLE ...................................................................... mmctx: only dispatch mm_state_fsm when not DETACHED/IDLE When the mm state fsm is in it's DETACH/IDLE state, there is no need to dispatch an detach event. Hides a log warning about an event not permitted. Change-Id: Ieec94bf0e762fd8c4ecc1e4dea5bb7c1cb23165c --- M src/sgsn/gprs_gmm.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 312c622..51b6296 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -192,10 +192,12 @@ switch(ctx->ran_type) { case MM_CTX_T_UTRAN_Iu: - osmo_fsm_inst_dispatch(ctx->iu.mm_state_fsm, E_PMM_PS_DETACH, NULL); + if (ctx->iu.mm_state_fsm->state != ST_PMM_DETACHED) + osmo_fsm_inst_dispatch(ctx->iu.mm_state_fsm, E_PMM_PS_DETACH, NULL); break; case MM_CTX_T_GERAN_Gb: - osmo_fsm_inst_dispatch(ctx->gb.mm_state_fsm, E_MM_GPRS_DETACH, NULL); + if (ctx->gb.mm_state_fsm->state != ST_MM_IDLE) + osmo_fsm_inst_dispatch(ctx->gb.mm_state_fsm, E_MM_GPRS_DETACH, NULL); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ieec94bf0e762fd8c4ecc1e4dea5bb7c1cb23165c Gerrit-Change-Number: 43697 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: pespin <pespin@sysmocom.de>