lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email )
Change subject: firmware: Add talloc_report_buf() encode the allocation by bits
......................................................................
Patch Set 9:
(1 comment)
File firmware/libcommon/source/pseudo_talloc.c:
https://gerrit.osmocom.org/c/simtrace2/+/43004/comment/ad31f039_7bde8407?usp... :
PS6, Line 101: return bitoff + 1;
+1 is always correct. if bitpos == 7 we might waste a byte.
Done
--
To view, visit
https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I3a8ddbe4100f342db2c59ad1fb9aa0014efc62b8
Gerrit-Change-Number: 43004
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 02 Sep 2026 20:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu