[M] Change in osmo-sgsn[master]: gprs_sndcp_xid: replace OSMO_ASSERT with if and return
Attention is currently required from: dexter, fixeria. lynxis lazus has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email ) Change subject: gprs_sndcp_xid: replace OSMO_ASSERT with if and return ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: +1 here after Pau's minors. But the functions don't check dst_length before writing to it. File src/sgsn/gprs_sndcp_xid.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/d0ed9086_9680b23e?usp... : PS2, Line 293: /* Encode P0 (see also: 3GPP TS 44.065, 6.6.2.1, Table 7a) */ For another commit: Check the dst_length before writing to dst. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia570b27a3670fed3aeb4779840292c5d216a1102 Gerrit-Change-Number: 43958 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Mon, 26 Oct 2026 11:54:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
lynxis lazus