Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email )

Change subject: sccp2sua: fix buffer overrun in osmo_isup_party_parse() ......................................................................

Patch Set 2:

(1 comment)

File src/sccp2sua.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163/comment/48f47869_f15350... : PS1, Line 74: if (in_num_bytes * 2 >= out_digits_size)

shouldn't you account for one extra byte in this check in the case it's even number of bytes? becaus […]

Note that the check is using `>=`, i.e. we accept the input only when `out_digits_size > in_num_bytes * 2`. Equivalent to `(in_num_bytes * 2 + 1) > out_digits_size`. Am I missing something here?