Attention is currently required from: manawyrm.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-e1d/+/43643?usp=email
to look at the new patch set (#4).
Change subject: octoi: rework frame_rifo logic to decompress frames on the output side ......................................................................
octoi: rework frame_rifo logic to decompress frames on the output side
The previous code tried to decompress frames against the last received frame regardless of the ordering (even when the frames got re-ordered by the network) and also when a frame didn't even arrive yet (rendering the jitter buffer almost useless).
This commit stores the compressed frame and the timeslot mask in the RIFO and only tries to decompress the frames in the RIFO pop logic (when we had time to receive the other frames before it).
The rifo->last_in_fn logic would also reset the counter back to an older frame even when a frame with a higher number was already received (fixed now).
Change-Id: I66af4f01ebb38ca1bdd8ffbc8135776322941230 --- M src/octoi/e1oip.c M src/octoi/e1oip.h M src/octoi/frame_rifo.c M src/octoi/frame_rifo.h M src/octoi/octoi.c M tests/rifo/rifo_test.c M tests/rifo/rifo_test.ok 7 files changed, 194 insertions(+), 39 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/43/43643/4