laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit As per EIRENE GSM-R SIM-Card FFFIS, EF_IC conatains records of 1+2+2+2 bytes, the network string table index is 16bit and not 8bit as we implemented so far. Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 --- M pySim/gsm_r.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/pySim/gsm_r.py b/pySim/gsm_r.py index edb5193..78c9ad9 100644 --- a/pySim/gsm_r.py +++ b/pySim/gsm_r.py @@ -211,7 +211,7 @@ self._construct = Struct('next_table_type'/NextTableType, 'id_of_next_table'/HexAdapter(Bytes(2)), 'ic_decision_value'/BcdAdapter(Bytes(2)), - 'network_string_table_index'/Int8ub) + 'network_string_table_index'/Int16ub) class EF_NW(LinFixedEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-MessageType: merged