laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31501 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: e1d: Remove useless call of handle_ts_trau_write() ...................................................................... e1d: Remove useless call of handle_ts_trau_write() handle_ts_trau_write() is called inside handle_ts_trau_read(). There is no need to call it when OSMO_FD_WRITE flag is set, because it is never set. Change-Id: Iccddcdb0975e8a043cc395c8908a157f5b376752 --- M src/input/e1d.c 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/e1d.c b/src/input/e1d.c index b638439..db4988f 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -284,8 +284,9 @@ case E1INP_TS_TYPE_TRAU: if (what & OSMO_FD_READ) ret = handle_ts_trau_read(bfd); - if (what & OSMO_FD_WRITE) - ret = handle_ts_trau_write(bfd); + /* handle_ts_trau_write() is called inside handle_ts_trau_read(). + * OSMO_FD_WRITE flag is not required here and will not be set. + */ break; case E1INP_TS_TYPE_RAW: if (what & OSMO_FD_READ) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iccddcdb0975e8a043cc395c8908a157f5b376752 Gerrit-Change-Number: 31501 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged