Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28809 ) Change subject: trxcon: rework trxcon_fsm, move into a separate file ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Patchset: PS4: 1+1 File src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h: https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/789b6112_331abde9 PS4, Line 61: uint8_t mode;

this used to be enum gsm_phys_chan_config in previous patch versions? I introduced this structure in the last patchset. It is used by both TRXCON_EV_SET_{CCCH,TCH}_MODE_REQ, while enum gsm_phys_chan_config is only applicable to TRXCON_EV_SET_CCCH_MODE_REQ. This is why I am using uint8_t.

-- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28809 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifaf63ead9dd180181358e771367b2a686ba159ca Gerrit-Change-Number: 28809 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 29 Jul 2022 14:21:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment