Attention is currently required from: neels, laforge, lynxis lazus. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data ...................................................................... Patch Set 10: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/72a00aa4_bd0bd496 PS7, Line 11: This violates the spec

No. The spec which this is about. I haven't found it again. Sorry. I do not think that this is critical.

https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/1a654e1b_c1fbe49b PS7, Line 17: premium

premium means just a different profile. E.g. […] Done

File include/osmocom/hlr/hlr.h: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/de2738d3_57e51bfd PS10, Line 67: } pdp_profile;

There might be different ps related settings in the future. Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f Gerrit-Change-Number: 32512 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Fri, 09 Jun 2023 15:47:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu> Comment-In-Reply-To: dexter <pmaier@sysmocom.de> Gerrit-MessageType: comment