Attention is currently required from: osmith, jolly, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31107 )
Change subject: layer23: Integreate mobile further into l23_app
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/host/layer23/src/mobile/app_mobile.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31107/comment/ab176e6f_ece83209
PS1, Line 495: L23_OPT_ARFCN
This one should be removed, because the mobile app
does not have -a. […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/31107/comment/09a26181_8338de38
PS1, Line 499: modem
copy-paste
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/31107/comment/93fb7a41_74c5886c
PS1, Line 504: copyright
Copyright (C) 2010-2015 Andreas Eversberg, Sylvain
Munaut, Holger Freyther, Harald Welte […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/31107
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3141b6cb4a0482970f434180ef8dda3af1d4aa0c
Gerrit-Change-Number: 31107
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 11:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment