Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31875 ) Change subject: bsc_subscriber: Optimize lookup of bsub by TMSI ...................................................................... Patch Set 2: (1 comment) Patchset: PS2:

I'm curious about your thoughts of rbtree vs. hash table. […] I really have no hard thoughts regarding one or another here, I could have used a hashtable too. Each has its pros and cons. Since hashtable means allocating more memory and we may want to add more lookup data structures for other MI types in the future (IMSI string, etc.) I thought rbtree was the easiest to replicate. Also because I already had code around from previous patches. I think simply rbtree is good enough (TM).

It's not like we are moving millions of objects so the difference shouldn't be that much, and the time the analysis that would require is probably not worth it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If27429e715ef4b327177e427249e68321a6e83cc Gerrit-Change-Number: 31875 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Tue, 14 Mar 2023 10:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment