Attention is currently required from: jolly, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35557?usp=email ) Change subject: Add new protocol command and events for Sa bits and line states ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/e1d/proto.h: https://gerrit.osmocom.org/c/osmo-e1d/+/35557/comment/ff445229_83bd35da PS1, Line 83: E1DP_EVT_SABITS = 0x7f, any specific reason to go with 0x7f rather than the next free +1, i.e. 0x46 ? -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4c20ec19fa3d9cce82c8199b38d173aa272fb07d Gerrit-Change-Number: 35557 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: tnt <tnt@246tNt.com> Gerrit-Comment-Date: Sun, 14 Jan 2024 17:24:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment