Attention is currently required from: laforge, tnt, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32174 ) Change subject: contrib/ber: Avoid regenerating codec_bit_class.h every build ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File contrib/ber/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/32174/comment/2c7d07f9_b20514e0 PS1, Line 28: echo "PESPIN: $(top_srcdir)/contrib/ber/codec_bit_class.h"

AH yes sorry I just added that while debugging :P Done

https://gerrit.osmocom.org/c/osmo-bts/+/32174/comment/3febc6a3_e89289e4 PS1, Line 29: $(AM_V_GEN)./$< > $(top_srcdir)/contrib/ber/codec_bit_class.h

"No newline at end of right file" Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I97efdb4ee00537fcae191b4267d0211d582ef372 Gerrit-Change-Number: 32174 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: tnt <tnt@246tNt.com> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 11:23:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment