Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42237?usp=email ) Change subject: docs/smpp-ota-tool: Add documentation/tutorial ...................................................................... Patch Set 1: (10 comments) File docs/smpp-ota-tool.rst: https://gerrit.osmocom.org/c/pysim/+/42237/comment/6f384f16_3412eeb9?usp=ema... : PS1, Line 5: cards an eUICC must not be a card, in fact most often it is not. I would just write "of SIM/USIM/UICC/eUICC." or something like that. https://gerrit.osmocom.org/c/pysim/+/42237/comment/a1dca5bb_cf9dcc7e?usp=ema... : PS1, Line 6: SMPP : server "... SMPP server (such as a production SMSC of a live cellular network) as well." I think it makes sense to clarify that one can use this in a production setup if one is an operator and has SMPP access to ones own SMSC. https://gerrit.osmocom.org/c/pysim/+/42237/comment/a433b6d8_ae166f51?usp=ema... : PS1, Line 17: a se it's not "a set" but "sets of keys".. Somehow the paragraph doesn't really make it clear that the SCP80 keys must be used. You just say that the SCP80 protocol is used, and not that therem ight be different sets of keys for different SCPs and one of the SCP80 keysets must be used. https://gerrit.osmocom.org/c/pysim/+/42237/comment/5a0511ef_2bd90920?usp=ema... : PS1, Line 17: card we have many more instances of "card" in the document, it seems. Maybe add an initial paragraph at the top that whenever "SIM" is used, any of UICC/USIM/ISIM/eUICC/eSIM is actually meant? Or one could also do the same with the word "card": Define the word "card" in the context of this document as "any SIM/USIM/ISIM/UICC/eUICC/eSIM whether or not it is in a physical card or solder form-factor"? https://gerrit.osmocom.org/c/pysim/+/42237/comment/c23d3254_fea15b03?usp=ema... : PS1, Line 26: The KIK is not used in the scope of SCP80. oh, are you sure? That means you cannot deploy new SCP80 (or other) keys via SCP80? I would have assumed that using RAM one could also issue PUT KEY and then the KIK would be used? Do you have a spec reference for your statement that it's not used? https://gerrit.osmocom.org/c/pysim/+/42237/comment/29e48c59_b5678c82?usp=ema... : PS1, Line 28: programmed into the issuer security domain (ISD) the keyset doesn't have to be in the ISD. I think any security domain (whether issuer or supplementary) could in theory specify its own material? Might be best to just say "security domain" without being too specific. https://gerrit.osmocom.org/c/pysim/+/42237/comment/d24b1c40_3c72e02a?usp=ema... : PS1, Line 84: A0A40000027F20 might be worth using formatting instructions to use monospaced font for all APDUs or other hex-strings https://gerrit.osmocom.org/c/pysim/+/42237/comment/24338766_a56d9080?usp=ema... : PS1, Line 86: is received by the SIM RFM application and then executed. This method poses some limitations that have to be taken into might be worth stating that he SIM RFM application is "on the card" https://gerrit.osmocom.org/c/pysim/+/42237/comment/72d2a4ae_e9bf2c30?usp=ema... : PS1, Line 115: : To prevent this, we may include a replay protection counter within the message. In this case, the MSL indicates that a : replay protection counter is not required. However, to extended the security of our messages, we may chose to use a : counter anyway. In the following example, we will encode a counter value of 100. We will instruct the card to make sure : that the value we send is higher than the counter value that is currently stored in the card. it might be worth mentioning at some earlier point that the MSL of the card may be different for different card types/profiles, and that cards beyond lab/experimentation use should ideally have a MSL that makes the use of the counter mandatory. It's just the sysmoISIM-SJS1/SJA2/SJA5 that do not have a MSL requiring a counter as that makes it easier for lab/research type use. https://gerrit.osmocom.org/c/pysim/+/42237/comment/7d9b144f_664ade33?usp=ema... : PS1, Line 162: overlap "... it will not wrap on overflow ... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If0d18a263f5a6dc035b90f5c5c6a942d46bbba49 Gerrit-Change-Number: 42237 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:04:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No