lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43600?usp=email )

(

1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gprs_gmm: refactor handling of GMM Detach Accept into own function ......................................................................

gprs_gmm: refactor handling of GMM Detach Accept into own function

Change-Id: Iae846bbff0df04295a1579017117b3e84fa29157 --- M src/sgsn/gprs_gmm.c 1 file changed, 9 insertions(+), 3 deletions(-)

Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified

diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index fcb243f..778457d 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1501,6 +1501,14 @@ return rc; }

+/* CHapter 9.4.6: MT Detach Ack */ +static int gsm48_rx_gmm_det_accept(struct sgsn_mm_ctx *ctx, struct msgb *msg) +{ + LOGMMCTXP(LOGL_INFO, ctx, "-> DETACH ACK\n"); + mm_ctx_cleanup_free(ctx, "GMM DETACH ACK"); + return 0; +} + /* Chapter 9.4.15: Routing area update accept */ static int gsm48_tx_gmm_ra_upd_ack(struct sgsn_mm_ctx *mm) { @@ -2099,9 +2107,7 @@ case GSM48_MT_GMM_DETACH_ACK: if (!mmctx) goto null_mmctx; - LOGMMCTXP(LOGL_INFO, mmctx, "-> DETACH ACK\n"); - mm_ctx_cleanup_free(mmctx, "GMM DETACH ACK"); - rc = 0; + rc = gsm48_rx_gmm_det_accept(mmctx, msg); break; case GSM48_MT_GMM_ATTACH_COMPL: if (!mmctx)