Attention is currently required from: jolly.

lynxis lazus has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email )

Change subject: Add maintenance mapping support to osmo-remsim-server ......................................................................

Patch Set 2:

(5 comments)

Patchset:

PS2: Would be the name SLMAP_S_SUSPEND more precise than SLMAP_S_INACTIVE? Are there ttcn3 testcases already?

Commit Message:

https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/cdf45c16_b89d97d3?u... : PS2, Line 19: * The normal mapping is deleted and put into INACTIVE state. From the bankd side, the mapping is deleted, but for the server this is kept, right?

File src/server/rspro_server.c:

https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/ad14f295_0ce60ccc?u... : PS2, Line 385: llist_for_each_entry(map, &slotmaps->mappings, list) { Is this still correct? Couldn't be there 2 mappings here which are both entering S_NEW state?

https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/e326f43e_bec346ee?u... : PS2, Line 462: clinet client

https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/8d73ad94_72be0e45?u... : PS2, Line 466: n being?