Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email ) Change subject: [WIP] mobile: integrate V.110 TA & soft-UART from libosmocore ...................................................................... Patch Set 1: (2 comments) File src/host/layer23/src/mobile/tch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13596): https://gerrit.osmocom.org/c/osmocom-bb/+/35582/comment/c2e92626_aa6f6018 PS1, Line 171: else else is not generally useful after a break or return File src/host/layer23/src/mobile/tch_data.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13596): https://gerrit.osmocom.org/c/osmocom-bb/+/35582/comment/31cccf2a_fa5fc9fe PS1, Line 315: #if 1 Consider removing the #if 1 and its #endif -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7ac9c0e5010730fa4d8bc7a7a3c7ff85e11731c0 Gerrit-Change-Number: 35582 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 15 Jan 2024 18:39:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment