Attention is currently required from: fixeria, daniel, lynxis lazus.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/32176
)
Change subject: gprs: fix has_valid_nsvc(): permit local udp port 0
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
(Copy-pasting from previous Change-Id:)
The question here is more: does it make sense from network architecture point of view that
PCU binds to a randomly available port for Gb?
AFAIU it makes no sense, since it needs to bind to a specific port also known by the SGSN
so that it knows where to send packets to. Or is the SGSN available to learn dynamically
of the PCU by listening() on its port?
Maybe something @lynxis or @daniel will be able to answer better.
If it makes no sense that the PCU can bidn to a random port, then sure, let's disallow
passing bind port 0. But let's then explain correctly the rationale behind it, which
is wrong in current version of this patch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32176
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0afd83e77f3daeeb082e7db911610428b5bc587c
Gerrit-Change-Number: 32176
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 31 Mar 2023 14:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment