Attention is currently required from: osmith, laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32786 )
Change subject: Migrate network identifier fields to modern osmocom structures ......................................................................
Patch Set 3:
(5 comments)
File src/host/layer23/src/common/subscriber.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/5ef52478_60c65ae5 PS3, Line 414: %s The table will be distorted when 2 digit MNC is displayed. You should insert a space if mnc_3_digits is false or maybe use "%-3s".
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/2870458a_731ccbc9 PS3, Line 495: %s dito
File src/host/layer23/src/mobile/gsm322.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/661a9ab1_3bf5a8d7 PS3, Line 4806: %s The table will be distorted when 2 digit MNC is displayed. You should insert a space if mnc_3_digits is false or maybe use "%-3s".
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/db71d753_ec9bcec4 PS3, Line 4837: %s dito
https://gerrit.osmocom.org/c/osmocom-bb/+/32786/comment/3bc30ef9_f46994ff PS3, Line 4879: %s dito