Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email ) Change subject: Use struct gtp_addr for ms_addr and sgsn_addr ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/34734/comment/afa621d5_358c59d8 PS1, Line 7: update to p

Please expand a little bit what the change does. Like "Introduce a union in struct foo ... […] Done

File src/internal.h: https://gerrit.osmocom.org/c/libgtpnl/+/34734/comment/f722a4bb_14f76d4a PS1, Line 22: } ip;

I would agree, it should be ip4/ip6, or something else that is clearly understood. […] Done

-- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ifc7e3b03a723fb544d1c7b789101102b2c27b60e Gerrit-Change-Number: 34734 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment