Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33308 ) Change subject: mgcp-client: Add keepalive feature ...................................................................... Patch Set 4: (2 comments) File include/osmocom/mgcp_client/mgcp_client_internal.h: https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/c97514b2_73cdc462 PS4, Line 22: conn_up one mihgt have differentiated betwween UP, DOWN and UNKNOWN. This way we wouldn't print "UP" on a system with disabled keepalives, where we actually don't know if it's up. File src/libosmo-mgcp-client/mgcp_client_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/36825a5e_9e5ebc93 PS4, Line 676: pool_member->clien one could also keep the bool conn_up and add a check here if keepalives are actually enabled. If yes, "UP". If not: "UNKNOWN". -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3dc74c78548d017f272da863d5282dc5e0020ca3 Gerrit-Change-Number: 33308 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:49:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment