[S] Change in libosmocore[master]: gsup.h: define newly added PCO IE
Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email ) Change subject: gsup.h: define newly added PCO IE ...................................................................... Patch Set 3: (2 comments) This change is ready for review. File include/osmocom/gsm/gsup.h: https://gerrit.osmocom.org/c/libosmocore/+/36024/comment/a89bfc8b_a32296d6 PS3, Line 412: const uint8_t *pco;
Should I check for the PCO lenght? I would keep the pointer+length as we do it in most cases in the […] Done
File src/gsm/gsup.c: https://gerrit.osmocom.org/c/libosmocore/+/36024/comment/1843b3cc_d3377d8c PS3, Line 881: msgb_tlv_put(msg, OSMO_GSUP_PCO_IE, gsup_msg->pco_len, gsup_msg->pco); Yeah I think we can check for pco_len <= 251 here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f9de90c7c67fe194b441a9d118eba70f09afb5e Gerrit-Change-Number: 36024 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Tue, 27 Feb 2024 12:33:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu> Gerrit-MessageType: comment
participants (1)
-
pespin