laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27043 ) Change subject: icE1usb: Fix ordering of USB interface numbers ...................................................................... icE1usb: Fix ordering of USB interface numbers The USB spec requires interface numbers to be in sequential order, and the existing firmware fails that requirement, as is shown by the Chapter9 test suite ("USB30CV"). With this patch applied, the USB30CV Chapter9 test suite passes. Change-Id: I6a5434447ee20f77ce0ba9e7b1884cbd5b466439 --- M firmware/ice40-riscv/icE1usb/usb_desc_ids.h 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/43/27043/1 diff --git a/firmware/ice40-riscv/icE1usb/usb_desc_ids.h b/firmware/ice40-riscv/icE1usb/usb_desc_ids.h index 3fbc417..dadf4c6 100644 --- a/firmware/ice40-riscv/icE1usb/usb_desc_ids.h +++ b/firmware/ice40-riscv/icE1usb/usb_desc_ids.h @@ -8,9 +8,9 @@ #pragma once #define USB_INTF_E1(p) (0 + (p)) -#define USB_INTF_DFU 2 -#define USB_INTF_GPS_CDC_CTL 3 -#define USB_INTF_GPS_CDC_DATA 4 +#define USB_INTF_GPS_CDC_CTL 2 +#define USB_INTF_GPS_CDC_DATA 3 +#define USB_INTF_DFU 4 #define USB_INTF_NUM 5 #define USB_EP_E1_IN(p) (0x82 + (3 * (p))) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I6a5434447ee20f77ce0ba9e7b1884cbd5b466439 Gerrit-Change-Number: 27043 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-MessageType: newchange