Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32989 )
Change subject: add doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg
......................................................................
Patch Set 2:
(2 comments)
File doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32989/comment/f6b20c28_f446d772
PS2, Line 13: hnbap-allow-tmsi 1
this line shows as not really interesting in this
example? Why not using the default?
i think i just copied some other file.
in general it makes sense to always allow TMSI for HNBAP: we don't even care about
HNBAP UE foo at all -- we ACK it but it has zero effect on RANAP where the business
happens.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32989/comment/d4172bef_4ae61150
PS2, Line 19: log stderr
usually we put log sections at the top.
is there
a reason?
i figure it is actually the least important bit of config, so why not put it in the
bottom...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32989
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I42c3b434a7339cc3efb27b43c893cfb734de9ca4
Gerrit-Change-Number: 32989
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 May 2023 22:46:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment