Change in osmo-bsc[master]: pcu_sock: check size of primitive
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29361 ) Change subject: pcu_sock: check size of primitive ...................................................................... Patch Set 1: (5 comments) File include/osmocom/bsc/pcu_if.h: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/11eb5f28_92e8e9a4 PS1, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/1dff3189_4e103130 PS1, Line 8: #define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) space prohibited before that close parenthesis ')' File src/osmo-bsc/pcu_sock.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/a806d8ba_85a8f7a1 PS1, Line 451: #define CHECK_IF_MSG_SIZE(prim_len, prim_msg) \ Macros with flow control statements should be avoided Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/5493025c_54894d7a PS1, Line 451: #define CHECK_IF_MSG_SIZE(prim_len, prim_msg) \ do {} while (0) macros should not be semicolon terminated Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-883): https://gerrit.osmocom.org/c/osmo-bsc/+/29361/comment/dc52e197_dad7c4b8 PS1, Line 459: } while(0); space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I247c6f4b5a7a22d17a060a558c4ceb9221ca7351 Gerrit-Change-Number: 29361 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 15 Sep 2022 12:53:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
Jenkins Builder