Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35659?usp=email ) Change subject: Introduce ue_fsm ...................................................................... Patch Set 1: (1 comment) File src/ue_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35659/comment/56a57521_4b621... PS1, Line 83: {stop, Err, Data}

Maybe a default case would be a good idea? I just mentioning this since […] Thanks for the feedback/tip. I know lots of stuff needs to be still improved, but I plan to do that in small steps while adding functionalities and tests. Ideally I'd do that in one run but realistically it's not possible given all the stuff that needs to be implemented and our current level of erlang (learning as we write).

Right now I'm at the time of writing a proof of concept code passing the most usual scenarios. Once that's in place we can start thinking at improving error cases. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0c960c4c250458384ed706a99582ec52083019f6 Gerrit-Change-Number: 35659 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jan 2024 16:49:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier@sysmocom.de> Gerrit-MessageType: comment