[L] Change in upf-benchmark[master]: gtplab-sysmo2025: Initial tunend test setup
Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39468?usp=email ) Change subject: gtplab-sysmo2025: Initial tunend test setup ...................................................................... Patch Set 7: (4 comments) File testsuites/gtplab-sysmo2025/tunend/README.md: https://gerrit.osmocom.org/c/upf-benchmark/+/39468/comment/6b8d6e9e_3332e0cc... : PS7, Line 2: towards UPF on its 1st iface and which which should be sent back decapsulated (tunend) towards CN and received at TRex 2nd interface.
wrap this line? Done
https://gerrit.osmocom.org/c/upf-benchmark/+/39468/comment/e0216506_d302b05c... : PS7, Line 14: ----
Use \`\`\` instead of --- to make a markdown code block Done
File testsuites/gtplab-sysmo2025/tunend/trex/gtpu_topo.py: https://gerrit.osmocom.org/c/upf-benchmark/+/39468/comment/c9e0edba_53d70746... : PS7, Line 17: return ".".join(li)
add a new line afterwards? (or two as in PEP-8) Done
File testsuites/gtplab-sysmo2025/tunend/upf/osmo-upf/configure.sh: https://gerrit.osmocom.org/c/upf-benchmark/+/39468/comment/f6c15220_5961061e... : PS7, Line 34: sudo ip addr add 172.16.32.1/24 dev $IFACE_RAN || true;
; is not needed at the end of these lines (same below) Done
-- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I834b62d29c8dcf2553fc665821135fb08a8bae9e Gerrit-Change-Number: 39468 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Thu, 20 Feb 2025 13:26:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de>
participants (1)
-
pespin