neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35489?usp=email ) Change subject: rua: move from ERROR to DEBUG log: stray RUA Disconnect ...................................................................... rua: move from ERROR to DEBUG log: stray RUA Disconnect Related: SYS#6602 Change-Id: Ib55c254190f46f24981e4394d8d5cf017070118d --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/89/35489/1 diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 84bd817..d73f22d 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -226,6 +226,7 @@ struct msgb *ranap_msg = NULL; struct hnbgw_context_map *map = NULL; bool is_ps; + int logl; switch (cN_DomainIndicator) { case RUA_CN_DomainIndicator_cs_domain: @@ -250,6 +251,7 @@ } map = context_map_find_by_rua_ctx_id(hnb, context_id, is_ps); + logl = LOGL_ERROR; switch (rua_procedure) { case RUA_ProcedureCode_id_Connect: @@ -270,10 +272,16 @@ } break; + case RUA_ProcedureCode_id_Disconnect: + /* For RUA Disconnect, do not spam the ERROR log. It is just a stray Disconnect, no harm done. + * Context: some CN are known to rapidly tear down SCCP without waiting for RUA to disconnect gracefully + * (IU Release Complete). Such CN would cause ERROR logging for each and every released context map. */ + logl = LOGL_DEBUG; + /* fall thru */ default: /* Any message other than Connect must have a valid RUA context */ if (!map) { - LOGHNB(hnb, DRUA, LOGL_ERROR, "rx RUA %s for unknown RUA context %u\n", + LOGHNB(hnb, DRUA, logl, "rx RUA %s for unknown RUA context %u\n", rua_procedure_code_name(rua_procedure), context_id); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib55c254190f46f24981e4394d8d5cf017070118d Gerrit-Change-Number: 35489 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: newchange