laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/28278 ) Change subject: cards: populate ADM1 key reference member ...................................................................... cards: populate ADM1 key reference member In class SimCard, we specify the key reference for ADM1 as 0x04. in the UsimCard class, which inherits from SimCard nothing is specified, even though ETSI TS 102 221 specifies 0x0A as key reference. Lets set the member in UsimCard accordingly to be closer to the spec. Note: For the moment this is a cosmetic fix, it does not change the behaviour since all card classes derived from UsimCard set the key reference properly. Change-Id: I96af395b1832f4462a6043cca3bb3812fddac612 --- M pySim/cards.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/cards.py b/pySim/cards.py index b186044..18e4ef3 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -348,6 +348,9 @@ def __init__(self, ssc): super(UsimCard, self).__init__(ssc) + # See also: ETSI TS 102 221, Table 9.3 + self._adm_chv_num = 0xA0 + def read_ehplmn(self): (res, sw) = self._scc.read_binary(EF_USIM_ADF_map['EHPLMN']) if sw == '9000': -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96af395b1832f4462a6043cca3bb3812fddac612 Gerrit-Change-Number: 28278 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-MessageType: merged