Attention is currently required from: pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31111 )
Change subject: pcu_sock: complain when not PDCH is available at all
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I don't really see the point in printing that
information, specially as NOTICE. […]
Agreeing with Pau here.
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31111/comment/b6505260_24c55144
PS1, Line 165: found_pdch
no need for an additional variable, simply check if: trx_info->pdch_mask == 0.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31111
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3e5409cd798f6027404c0ff95297af850e516c4
Gerrit-Change-Number: 31111
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Jan 2023 18:28:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment