Attention is currently required from: jolly.

dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43056?usp=email )

Change subject: V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa ......................................................................

Patch Set 1:

(3 comments)

File src/ipa/libipa/esipa_init_auth.h:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/e80c9040_f2430c2c?... : PS1, Line 19: TransactionId_t *eim_transaction_id; As it seems there is a tab instead of a space between type and member name. The member name is consistent, however in other code locations we use struct OCTET_STRING to declare the type.

(here the name of the struct meber is consistent)

File src/ipa/libipa/proc_cmn_mtl_auth.h:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/35c58fc0_6b9ed194?... : PS1, Line 19: TransactionId_t *eim_transaction_id; maybe declare this as struct OCTET_STRING *eim_transaction_id?

It could also make sense to apply some refactoring, so that we consistently use TransactionId_t throughout the entire codebase. What we should not do is to mix the two type names, even when they are the same under to hood.

We may also check if it would work to declare the eim_transaction_id as const n the pars and req structs.

File src/ipa/libipa/proc_indirect_prfle_dwnld.h:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43056/comment/d7702c23_4a653703?... : PS1, Line 18: TransactionId_t *eim_transaction_id; (see the other comments)