Attention is currently required from: fixeria, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31558
)
Change subject: pcu_l1_if_phy: add header file for struct gsmtap_inst
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/pcu_l1_if_phy.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31558/comment/aec2dbea_a9ee014c
PS2, Line 4: #include <osmocom/core/gsmtap_util.h>
It would be enough to add a forward declaration.
I find it more correct to add the header here since this declaration is provided by
some external dependency.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31558
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9b859c4f7906f31547549d4ff7751fb720519270
Gerrit-Change-Number: 31558
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 16:31:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment