Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255 )
Change subject: dia2gsup: Introduce new error scenario tests
......................................................................
Patch Set 1:
(1 comment)
File dia2gsup/DIA2GSUP_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/30921ca3_74a0…
PS1, Line 345: TC_authinfo_gsup_err_imsi_unknown
Because it's not the same scenario. […]
It
depends on the angle you look at it. All these new testcases verify the scenario of
getting `GSUP_SAI_ERR` in response to `GSUP_SAI_REQ` and expect a specific cause in the
`DIA_AIA_ERR`. The only variable part here is the GSUP/DIAMETER case values. It's not
like you're sending different messages not sending them conditionally...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea
Gerrit-Change-Number: 34255
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Aug 2023 08:12:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment