Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540 )
Change subject: PCU_Tests: test NACC procedure with UTRAN and E-UTRAN cell
......................................................................
Patch Set 2:
(4 comments)
File pcu/PCU_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540/comment/daf078d2_caad…
PS2, Line 5336: private function f_outbound_nacc_success_utran_eutran(inout GprsMS ms,
PCUIF_info_ind info_ind,
I think you can really split the UTRAN and EUTRAN cases in different functions, it will be
easier to extend or modify in the future.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540/comment/07fb9275_76f1…
PS2, Line 5351: cell_chg_notif :=
ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF_EUTRAN(ms.ul_tbf.tfi, req_earfcn, phys_layer_cell_id);
If this is the only thing that changes, maybe pass template (value) RlcmacUlCtrlMsg
cell_chg_notif as a param?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540/comment/9ec037dd_b258…
PS2, Line 5378: private function f_outbound_nacc_success(inout GprsMS ms, PCUIF_info_ind
info_ind,
This one should be renamed to _geran in another patch maybe?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540/comment/84c6e3e3_1157…
PS2, Line 5427: function f_TC_nacc_outbound_success(integer ran_type) runs on
RAW_PCU_Test_CT {
please enum or string, this is totally hack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idae86a458fd44ac81bab183ed1865b1c1bdbfd66
Gerrit-Change-Number: 33540
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jun 2023 15:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment