Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556 ) Change subject: library/RSL_Types: RSL_SpeechAlgo: support CSD ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File library/RSL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/22fcb8cb_4ff6… PS2, Line 397: SL_CMOD_DT_NT2 ('00100010'B), : RSL_CMOD_DT_NT3 ('00100011'B), : RSL_CMOD_DT_NT4 ('00101001'B), : RSL_CMOD_DT_NT5 ('00101010'B), : RSL_CMOD_DT_NT6 ('00101011'B), : RSL_CMOD_DT_NT7 ('00110100'B), : RSL_CMOD_DT_NT9 ('00011000'B), : RSL_CMOD_DT_T1 ('01111000'B), : RSL_CMOD_DT_T2 ('01111001'B), : RSL_CMOD_DT_T3 ('01011000'B), : RSL_CMOD_DT_T4 ('01010000'B), : RSL_CMOD_DT_T5 ('01010001'B), : RSL_CMOD_DT_T6 ('01010010'B), : RSL_CMOD_DT_T7 ('01010011'B), : RSL_CMOD_DT_T8 ('01010100'B), : RSL_CMOD_DT_T9 Why would those be called _NT1 or _T2 rather than something that indicates their actual data rate? like DT_NT_6k / DT_NT_12k / DT_T_14k4 / ... ? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ief2d95c7e9d71afb26fa74da755294226c8e158d Gerrit-Change-Number: 31556 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 19:03:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment