Attention is currently required from: fixeria, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/35051?usp=email )
Change subject: implement re-assignment to match codecs
......................................................................
Patch Set 6:
(2 comments)
This change is ready for review.
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/35051/comment/a3383a1b_5f76f052
PS4, Line 276: LOG_TRANS_CAT_SRC(trans, DMNCC, LOGL_ERROR, file, line, "%s %s:
invalid SDP message (trying anyway)\n",
why 2 log calls here?
one is ERROR
<short>
the other is DEBUG <long complete SDP payload>
File src/libmsc/msc_a.c:
https://gerrit.osmocom.org/c/osmo-msc/+/35051/comment/e67182d0_18e79211
PS4, Line 639: void msc_a_tx_assignment(struct msc_a *msc_a)
msc_a_tx_assignment_cmd
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/35051?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8760feaa8598047369ef8c3ab2673013bac8ac8a
Gerrit-Change-Number: 35051
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Nov 2023 02:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment