neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31703 ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: codecs: compose HO Req Ch Type from cc.codecs ...................................................................... codecs: compose HO Req Ch Type from cc.codecs Change-Id: Iba7a1a87ec5e6b487f763e84d60ed285da7b8fe1 --- M src/libmsc/msc_ho.c 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c index e11abcf..2f25ca8 100644 --- a/src/libmsc/msc_ho.c +++ b/src/libmsc/msc_ho.c @@ -413,10 +413,11 @@ osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.kc128, sizeof(msc_a->geran_encr.kc128)) : "-"); - if (msc_a->cc.active_trans) { - if (mncc_bearer_cap_to_channel_type(&channel_type, &msc_a->cc.active_trans->bearer_cap)) { + if (cc_trans) { + if (sdp_audio_codecs_to_gsm0808_channel_type(&channel_type, + &cc_trans->cc.codecs.result.audio_codecs)) { msc_ho_failed(msc_a, GSM0808_CAUSE_EQUIPMENT_FAILURE, - "Failed to encode Bearer Cap to Channel Type\n"); + "Failed to determine Channel Type for Handover Request message\n"); return; } ran_enc_msg.handover_request.geran.channel_type = &channel_type; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iba7a1a87ec5e6b487f763e84d60ed285da7b8fe1 Gerrit-Change-Number: 31703 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged