Attention is currently required from: laforge, pespin.

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 )

Change subject: common+trx: make uplink ECU optional ......................................................................

Patch Set 5:

(4 comments)

Patchset:

PS1:

I actually came to the same conclusion myself. […]

Done

File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/9e8e8c4e_49ee8d5d PS4, Line 809: bts->suppress_ul_ecu = false;

I wrote the code the way I did so that the default of having this UL ECU enabled would happen on its […]

Done

File src/osmo-bts-trx/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/8c4cfd7e_086f9347 PS4, Line 445: if (!trx->bts->suppress_ul_ecu)

if (trx->bts->use_ul_ecu)

Done

https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/81e5e9ea_ff275dbd PS4, Line 481: if (!trx->bts->suppress_ul_ecu)

if (trx->bts->use_ul_ecu)

Done