Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28824
)
Change subject: sbcap: Improve handling of WriteReplaceWarnResponse
......................................................................
Patch Set 3:
(2 comments)
File src/sbcap_link_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/3d610fee_8aee9bc8
PS3, Line 256: /* static const long asn_VAL_19_SBcAP_id_Cause = 1; */
did you leave this on purpose?
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/0f5a1dde_c1a94aa9
PS3, Line 264: SBcAP_Cause_missing_mandatory_element, pdu);
Looks like error with missing mandatory element is sent back even if cause is not
accepted. Is this how it should be? After reading the commit message, I would have
assumed:
if (cause == accepted) {
if (!ie) {
// tx error_ind_pdu: missing mandatory element
}
} else {
// ...
}
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28824
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I0a4d5bdbb6c4fd3870a4f4ebf226668b70fea06a
Gerrit-Change-Number: 28824
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 10:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment